Guset User is not translatable
- Tamas Szeidl
- Topic Author
- Offline
- New Member
-
Less
More
- Posts: 4
- Thank you received: 0
6 years 9 months ago #6531
by Tamas Szeidl
Guset User is not translatable was created by Tamas Szeidl
Hi there,
I'm using vReview 1.9.10 and durig creating Hungarian localization I noticed that the 'Guest User' string (e.g. the name displayed at the top the review panel for reviews made by guest users) is not translatable. I've created a language override, but according to Joomla 2.5 standards the language key (this is created from the string by converting to all uppercase) may not contain any whitespace.
To fix this behaviour I had to change a core file: components/com_review/controller.php on line 3373 by simply changing space to underscore (bold):
Since it is not advised to modify core files, please include this fix in your next release.
Thank you.
I'm using vReview 1.9.10 and durig creating Hungarian localization I noticed that the 'Guest User' string (e.g. the name displayed at the top the review panel for reviews made by guest users) is not translatable. I've created a language override, but according to Joomla 2.5 standards the language key (this is created from the string by converting to all uppercase) may not contain any whitespace.
To fix this behaviour I had to change a core file: components/com_review/controller.php on line 3373 by simply changing space to underscore (bold):
Code:
if(!empty($username)){
$userName = $username;
} else {
$userName = JText::_('GUEST_USER'); // added underscore
}
Since it is not advised to modify core files, please include this fix in your next release.
Thank you.
Please Log in to join the conversation.